Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • C chouette-core
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 36
    • Merge requests 36
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Infrastructure Registry
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Administrator
  • chouette-core
  • Merge requests
  • !281

Merged
Created Feb 02, 2018 by Administrator@rootMaintainer

5817 referential vehicle journeys index fix stop area kind a

  • Overview 0
  • Commits 3
  • Changes 5

Created by: teddywing

Fix a bug on ReferentialVehicleJourneys#index where since the StopArea filter didn't select kind, the initialiser couldn't set it.

  • Revert @albanpeignier's temporary fix for that page
  • Remove the kind initialiser. After a discussion with @ldonnet, it seems the initial value is only really needed on the StopAreas#new page. Instead, move the initial value setting to the template, defaulting the kind radio buttons to :commercial
  • Add a migration setting all existing non-commercial StopAreas to commercial to ensure we don't have records with nil kinds. @zog already wrote a migration for this, but it turns out the query needed to take into account NULL values, so no StopAreas were changed.
Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: 5817-referential-vehicle-journeys-index--fix-StopArea-kind-a